linux-kernel - Re: [PATCH] gpio: pca953x: Convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfPe=LUttjzGNTZocu4nCpEV7Va28wZWnTGAeZmajMdFg@mail.gmail.com>
Date:   Mon, 2 Oct 2023 08:58:28 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Mark Brown <broonie@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: pca953x: Convert to use maple tree register cache

On Fri, Sep 29, 2023 at 2:24 PM Mark Brown <broonie@...nel.org> wrote:
>
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  drivers/gpio/gpio-pca953x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index bdd50a78e414..528ccb59b52a 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -414,7 +414,7 @@ static const struct regmap_config pca953x_i2c_regmap = {
>         .volatile_reg = pca953x_volatile_register,
>
>         .disable_locking = true,
> -       .cache_type = REGCACHE_RBTREE,
> +       .cache_type = REGCACHE_MAPLE,
>         .max_register = 0x7f,
>  };
>
> @@ -430,7 +430,7 @@ static const struct regmap_config pca953x_ai_i2c_regmap = {
>         .volatile_reg = pca953x_volatile_register,
>
>         .disable_locking = true,
> -       .cache_type = REGCACHE_RBTREE,
> +       .cache_type = REGCACHE_MAPLE,
>         .max_register = 0x7f,
>  };
>
>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-gpio-pca953x-maple-b39b99cd90db
>
> Best regards,
> --
> Mark Brown <broonie@...nel.org>
>

Applied, thanks!

Bart