linux-kernel - Re: [PATCH v2] syscalls: Cleanup references to sys_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdada842-2a7e-5f1d-eea3-3d99b637c26b@intel.com>
Date:   Tue, 3 Oct 2023 10:47:06 -0700
From:   Sohil Mehta <sohil.mehta@...el.com>
To:     Arnd Bergmann <arnd@...db.de>, <linux-api@...r.kernel.org>,
        <linux-arch@...r.kernel.org>
CC:     Richard Henderson <richard.henderson@...aro.org>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        "Will Deacon" <will@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "Michal Simek" <monstr@...str.eu>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
        "Helge Deller" <deller@....de>,
        Michael Ellerman <mpe@...erman.id.au>,
        "Nicholas Piggin" <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        "Yoshinori Sato" <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
        "David S . Miller" <davem@...emloft.net>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>, Chris Zankel <chris@...kel.net>,
        "Max Filippov" <jcmvbkbc@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        "Namhyung Kim" <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        "Sergei Trofimovich" <slyich@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Rohan McLure <rmclure@...ux.ibm.com>,
        Andreas Schwab <schwab@...ux-m68k.org>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Brian Gerst <brgerst@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        <linux-alpha@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-ia64@...r.kernel.org>, <linux-m68k@...ts.linux-m68k.org>,
        <linux-mips@...r.kernel.org>, <linux-parisc@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <linux-s390@...r.kernel.org>,
        <linux-sh@...r.kernel.org>, <sparclinux@...r.kernel.org>,
        <linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH v2] syscalls: Cleanup references to sys_lookup_dcookie()

Arnd, is this a good candidate for 6.7? Though old, the patch applies
cleanly on 6.6-rc4. I can re-send this one if you would prefer that.

On 8/3/2023 2:44 PM, Sohil Mehta wrote:
> On 7/10/2023 11:51 AM, Sohil Mehta wrote:
>> commit 'be65de6b03aa ("fs: Remove dcookies support")' removed the
>> syscall definition for lookup_dcookie.  However, syscall tables still
>> point to the old sys_lookup_dcookie() definition. Update syscall tables
>> of all architectures to directly point to sys_ni_syscall() instead.
>>
>> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
>> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
>> Acked-by: Namhyung Kim <namhyung@...nel.org> # for perf
> 
> The patch has received a couple of additional Acks.
> 

Namely,

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Acked-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

> Does this seem like a valuable cleanup? If so, should it go through the
> asm-generic tree?
> 

The main motivation here is to make readers aware upfront (via the
syscall table itself) that no implementation exists for lookup_dcookie
instead of them searching for one and realizing the same. The syscall
tables do something similar for _sysctl().

Please let me know if this change seems unnecessary. I can drop the
annoying pings in that case.

Thanks,
Sohil