linux-kernel - Re: [PATCH 2/3] Input: cap11xx - Convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRux0yLPxZGLNF5A@google.com>
Date:   Mon, 2 Oct 2023 23:16:51 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Input: cap11xx - Convert to use maple tree register
 cache

Hi Mark,

On Sun, Oct 01, 2023 at 01:43:39AM +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  drivers/input/keyboard/cap11xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
> index 39ed3b9ddc65..77843ad15d4c 100644
> --- a/drivers/input/keyboard/cap11xx.c
> +++ b/drivers/input/keyboard/cap11xx.c
> @@ -174,7 +174,7 @@ static const struct regmap_config cap11xx_regmap_config = {
>  	.reg_defaults = cap11xx_reg_defaults,
>  
>  	.num_reg_defaults = ARRAY_SIZE(cap11xx_reg_defaults),
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,

I do not think these driver care much about the cache type. Optimal one
might even depend on the architecture. I wonder if we could have
something like REGCACHE_DEFAULT to signal that whatever is the "best
default" implementation it should be used?

Thanks.

-- 
Dmitry