linux-kernel - Re: [PATCH 2/3] Input: cap11xx - Convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2a9124d-29de-4116-8b03-532a17b563d1@sirena.org.uk>
Date:   Tue, 3 Oct 2023 13:16:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Input: cap11xx - Convert to use maple tree register
 cache

On Mon, Oct 02, 2023 at 11:16:51PM -0700, Dmitry Torokhov wrote:
> On Sun, Oct 01, 2023 at 01:43:39AM +0200, Mark Brown wrote:

> > -	.cache_type = REGCACHE_RBTREE,
> > +	.cache_type = REGCACHE_MAPLE,

> I do not think these driver care much about the cache type. Optimal one
> might even depend on the architecture. I wonder if we could have
> something like REGCACHE_DEFAULT to signal that whatever is the "best
> default" implementation it should be used?

I do sometimes wonder about that but there's also been enough issues
with the earlier stage of the transition and shaking out bugs in the
new code that it makes me a bit nervous about using one.  It has also
been a useful exercise to go through and actually look at the users, but
that could be done any time.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)