[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <881c99b5-f64e-4c74-1420-8eec08cca0ce@linux.intel.com>
Date: Tue, 3 Oct 2023 09:15:06 +0200
From: Amadeusz Sławiński
<amadeuszx.slawinski@...ux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
alsa-devel@...a-project.org
Cc: Mark Brown <broonie@...nel.org>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Cezary Rojewski <cezary.rojewski@...el.com>,
Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
Daniel Baluta <daniel.baluta@....com>,
linux-kernel@...r.kernel.org, sound-open-firmware@...a-project.org
Subject: Re: [PATCH v5 10/12] ASoC: Intel: Skylake: Move snd_hdac_i915_init to
before probe_work.
On 10/3/2023 8:55 AM, Amadeusz Sławiński wrote:
> On 10/2/2023 6:52 PM, Maarten Lankhorst wrote:
>> Now that we can use -EPROBE_DEFER, it's no longer required to spin off
>> the snd_hdac_i915_init into a workqueue. It's likely the whole workqueue
>> can be destroyed, but I don't have the means to test this.
>>
>> Removing the workqueue would simplify init even further, but is left
>> as exercise for the reviewer.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
>> Acked-by: Mark Brown <broonie@...nel.org>
>> Reviewed-by: Kai Vehmanen <kai.vehmanen@...ux.intel.com>
>> Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>
>> ---
>
> Isn't the convention that your Signed-off should be last when you are
> sending the patches? Or does it only apply to Signed-off lines
> themselves and other lines can be anywhere?
>
And rereading kernel documentation, it really seems to be a bit
ambiguous, well ignore the comment then.
Powered by blists - more mailing lists