linux-kernel - Re: [PATCH v6 1/3] media: dt-bindings: media: add rockchip-vip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRvTdm5cTMT1tHlM@pc-86.home>
Date:   Tue, 3 Oct 2023 10:40:22 +0200
From:   Mehdi Djait <mehdi.djait@...tlin.com>
To:     Rob Herring <robh@...nel.org>
Cc:     mchehab@...nel.org, heiko@...ech.de, ezequiel@...guardiasur.com.ar,
        hverkuil-cisco@...all.nl, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, paul.kocialkowski@...tlin.com,
        miquel.raynal@...tlin.com, maxime.chevallier@...tlin.com,
        luca.ceresoli@...tlin.com, thomas.petazzoni@...tlin.com,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 1/3] media: dt-bindings: media: add rockchip-vip

Hello Rob,

Thank you for the review!

On Mon, Oct 02, 2023 at 12:18:01PM -0500, Rob Herring wrote:
> On Fri, Sep 29, 2023 at 12:08:00PM +0200, Mehdi Djait wrote:
> > Add a documentation for the Rockchip Camera Interface controller
> > binding.
> > 
> > This controller can be found on platforms such as the PX30 or
> > RK1808, RK3128 and RK3288. The PX30 is the only platform
> > supported so far.
> > 
> > Signed-off-by: Mehdi Djait <mehdi.djait@...tlin.com>
> > ---
> >  .../bindings/media/rockchip-vip.yaml          | 91 +++++++++++++++++++
> 
> filename should match compatible.
> 
> >  1 file changed, 91 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/media/rockchip-vip.yaml b/Documentation/devicetree/bindings/media/rockchip-vip.yaml
> > new file mode 100644
> > index 000000000000..33c603209c39
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/rockchip-vip.yaml
> > @@ -0,0 +1,91 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/rockchip-vip.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Rockchip VIP Camera Interface
> > +
> > +maintainers:
> > +  - Mehdi Djait <mehdi.djait@...tlin.com>
> > +
> > +description: |-
> 
> Don't need '|-'.
> 
> > +  Rockchip Video Input Processor present on PX30, RK1808, RK3128 and RK3288
> 
> Write complete sentences.
> 
> 
> 
> > +
> > +properties:
> > +  compatible:
> > +    const: rockchip,px30-vip
> 
> I see 4 SoCs listed, but only 1 compatible.
> 

PX30 is the only SoC I have used to test the driver. What is the best
way to proceed here ? Change the description ?

ack for all the other comments. 

--
Kind Regards
Mehdi Djait