linux-kernel - Re: [PATCH v6 1/3] media: dt-bindings: media: add rockchip-vip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2863562-33dc-443c-950d-2024c07943a1@linaro.org>
Date:   Tue, 3 Oct 2023 11:17:37 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mehdi Djait <mehdi.djait@...tlin.com>,
        Rob Herring <robh@...nel.org>
Cc:     mchehab@...nel.org, heiko@...ech.de, ezequiel@...guardiasur.com.ar,
        hverkuil-cisco@...all.nl, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, paul.kocialkowski@...tlin.com,
        miquel.raynal@...tlin.com, maxime.chevallier@...tlin.com,
        luca.ceresoli@...tlin.com, thomas.petazzoni@...tlin.com,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 1/3] media: dt-bindings: media: add rockchip-vip

On 03/10/2023 10:40, Mehdi Djait wrote:

>>> +maintainers:
>>> +  - Mehdi Djait <mehdi.djait@...tlin.com>
>>> +
>>> +description: |-
>>
>> Don't need '|-'.
>>
>>> +  Rockchip Video Input Processor present on PX30, RK1808, RK3128 and RK3288
>>
>> Write complete sentences.
>>
>>
>>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: rockchip,px30-vip
>>
>> I see 4 SoCs listed, but only 1 compatible.
>>
> 
> PX30 is the only SoC I have used to test the driver. What is the best
> way to proceed here ? Change the description ?
> 

The best is to have bindings complete for all of the four SoCs, even if
you did not test the driver on them. The "complete" means
hardware-complete, so what the datasheet/spec is saying.

If anything is missing, could be added later.

You can change the description and drop other SoCs as well.

Best regards,
Krzysztof