[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <896c7657-e93e-4bd5-8a58-ad15cbfa834f@quicinc.com>
Date: Tue, 3 Oct 2023 20:12:46 +0530
From: Praveenkumar I <quic_ipkumar@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
<agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <vkoul@...nel.org>,
<kishon@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<gregkh@...uxfoundation.org>, <catalin.marinas@....com>,
<will@...nel.org>, <p.zabel@...gutronix.de>,
<geert+renesas@...der.be>, <arnd@...db.de>,
<neil.armstrong@...aro.org>, <nfraprado@...labora.com>,
<u-kumar1@...com>, <peng.fan@....com>, <quic_wcheng@...cinc.com>,
<quic_varada@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
<linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
CC: <quic_kathirav@...cinc.com>, <quic_nsekar@...cinc.com>,
<quic_srichara@...cinc.com>
Subject: Re: [PATCH 5/8] arm64: dts: qcom: ipq5332: Add clocks for USB
Super-Speed
On 9/30/2023 10:55 PM, Dmitry Baryshkov wrote:
> On 29/09/2023 11:42, Praveenkumar I wrote:
>> Add aux and lfps clocks in USB node for Super-Speed support.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> index b08ffd8c094e..1813b9fa4bb5 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> @@ -336,11 +336,16 @@ usb: usb@...8800 {
>> clocks = <&gcc GCC_USB0_MASTER_CLK>,
>> <&gcc GCC_SNOC_USB_CLK>,
>> <&gcc GCC_USB0_SLEEP_CLK>,
>> - <&gcc GCC_USB0_MOCK_UTMI_CLK>;
>> + <&gcc GCC_USB0_MOCK_UTMI_CLK>,
>> + <&gcc GCC_USB0_AUX_CLK>,
>> + <&gcc GCC_USB0_LFPS_CLK>;
>
> This looks like a strange change. Usually the DTB is considered to be
> the ABI, so older DTBs should continue to work with newer kernels. Is
> there a reason why the AUX and LFPS clocks were not a part of the
> original submission?
This AUX and LFPS clocks are required only when USB controller uses the
UNIPHY and works in 3.0. Original change added 2.0 support and used m31-phy.
>
>> +
>> clock-names = "core",
>> "iface",
>> "sleep",
>> - "mock_utmi";
>> + "mock_utmi",
>> + "aux",
>> + "lfps";
>> resets = <&gcc GCC_USB_BCR>;
>
--
Thanks,
Praveenkumar
Powered by blists - more mailing lists