linux-kernel - Re: [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5763999-7636-4ac5-a1ef-408892b5bdba@quicinc.com>
Date:   Tue, 3 Oct 2023 20:12:33 +0530
From:   Praveenkumar I <quic_ipkumar@...cinc.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <vkoul@...nel.org>,
        <kishon@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <gregkh@...uxfoundation.org>, <catalin.marinas@....com>,
        <will@...nel.org>, <p.zabel@...gutronix.de>,
        <geert+renesas@...der.be>, <arnd@...db.de>,
        <neil.armstrong@...aro.org>, <nfraprado@...labora.com>,
        <u-kumar1@...com>, <peng.fan@....com>, <quic_wcheng@...cinc.com>,
        <quic_varada@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <quic_kathirav@...cinc.com>, <quic_nsekar@...cinc.com>,
        <quic_srichara@...cinc.com>
Subject: Re: [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in
 USB node



On 9/30/2023 10:57 PM, Dmitry Baryshkov wrote:
> On 29/09/2023 11:42, Praveenkumar I wrote:
>> Add UNIPHY node in USB to support Super-speed. As the SS PHY has
>> pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi 
>> b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> index 1813b9fa4bb5..8fe4e45bfc18 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> @@ -349,8 +349,6 @@ usb: usb@...8800 {
>>                 resets = <&gcc GCC_USB_BCR>;
>>   -            qcom,select-utmi-as-pipe-clk;
>> -
>>               #address-cells = <1>;
>>               #size-cells = <1>;
>>               ranges;
>> @@ -363,8 +361,8 @@ usb_dwc: usb@...0000 {
>>                   clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>;
>>                   clock-names = "ref";
>>                   interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
>> -                phy-names = "usb2-phy";
>> -                phys = <&usbphy0>;
>> +                phy-names = "usb2-phy", "usb3-phy";
>> +                phys = <&usbphy0>, <&usbphy1>;
>
> Ah, I see now. Maybe usbphy_ss_0 or something like that would be a 
> better label for this PHY. I'd expect usbphy1 to be used for other 
> host than usbphy0.
Sure, will change it.
>
>>                   tx-fifo-resize;
>>                   snps,is-utmi-l1-suspend;
>>                   snps,hird-threshold = /bits/ 8 <0x0>;
>
--
Thanks,
Praveenkumar