linux-kernel - Re: [PATCH net-next] net: microchip: lan743x: improve throughput with rx timestamp config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231004110031.7e9c32e8@kernel.org>
Date:   Wed, 4 Oct 2023 11:00:31 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vishvambar Panth S <vishvambarpanth.s@...rochip.com>
Cc:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <bryan.whitehead@...rochip.com>, <unglinuxdriver@...rochip.com>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <richardcochran@...il.com>
Subject: Re: [PATCH net-next] net: microchip: lan743x: improve throughput
 with rx timestamp config

On Tue, 26 Sep 2023 21:26:58 +0530 Vishvambar Panth S wrote:
> +			netif_warn(adapter, drv, adapter->netdev,
> +				   "rx timestamp = %d is not supported\n",
> +				   rx_filter);

I addition to Jake's comments please also drop this warning.

> +			return -EINVAL;

And make sure this is the correct return code.
I thought -ERANGE was more appropriate here, but I could be wrong.