linux-kernel - Re: [PATCH net-next] net: microchip: lan743x: improve throughput with rx timestamp config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a49fa745b9bbf05dd6174a176a7749e5a683fe89.camel@microchip.com>
Date:   Thu, 5 Oct 2023 11:02:43 +0000
From:   <VishvambarPanth.S@...rochip.com>
To:     <kuba@...nel.org>
CC:     <Bryan.Whitehead@...rochip.com>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <pabeni@...hat.com>,
        <richardcochran@...il.com>, <UNGLinuxDriver@...rochip.com>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: microchip: lan743x: improve throughput with
 rx timestamp config

On Wed, 2023-10-04 at 11:00 -0700, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Tue, 26 Sep 2023 21:26:58 +0530 Vishvambar Panth S wrote:
> > +                     netif_warn(adapter, drv, adapter->netdev,
> > +                                "rx timestamp = %d is not
> > supported\n",
> > +                                rx_filter);
> 
> I addition to Jake's comments please also drop this warning.
> 
Hi Jakub,
Thanks for the comments. Sure, will drop the warning or add it as debug
message.

> > +                     return -EINVAL;
> 
> And make sure this is the correct return code.
> I thought -ERANGE was more appropriate here, but I could be wrong.

Will check and add the appropriate return code in v2 patch.