[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231004135833.6efdbced@kernel.org>
Date: Wed, 4 Oct 2023 13:58:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: MD Danish Anwar <danishanwar@...com>
Cc: Andrew Lunn <andrew@...n.ch>, Roger Quadros <rogerq@...nel.org>,
Vignesh Raghavendra <vigneshr@...com>,
Richard Cochran <richardcochran@...il.com>,
Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>,
"David S. Miller" <davem@...emloft.net>, <vladimir.oltean@....com>,
Simon Horman <horms@...nel.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <srk@...com>,
<r-gunasekaran@...com>, <linux-omap@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
Roger Quadros <rogerq@...com>,
Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [PATCH net-next v3] net: ti: icssg_prueth: add TAPRIO offload
support
On Thu, 28 Sep 2023 16:00:00 +0530 MD Danish Anwar wrote:
> +/**
> + * Config state machine variables. See IEEE Std 802.1Q-2018 8.6.8.4
> + */
Please use correct kdoc format with all members documented or not use
the /** marker.
> +struct tas_config_list {
> + /* New list is copied at this time */
> + u64 config_change_time;
> + /* config change error counter, incremented if
> + * admin->BaseTime < current time and TAS_enabled is true
> + */
> + u32 config_change_error_counter;
> + /* True if list update is pending */
> + u8 config_pending;
> + /* Set to true when application trigger updating of admin list
> + * to active list, cleared when configChangeTime is updated
> + */
> + u8 config_change;
> +};
--
pw-bot: cr
Powered by blists - more mailing lists