[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8a936a54-9c20-4a3b-ac2c-ae65cd22698f@linaro.org>
Date: Wed, 4 Oct 2023 08:51:17 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: yuji2.ishikawa@...hiba.co.jp, hverkuil@...all.nl,
laurent.pinchart@...asonboard.com, mchehab@...nel.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, nobuhiro1.iwamatsu@...hiba.co.jp
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add
Toshiba Visconti Video Input Interface
On 04/10/2023 01:10, yuji2.ishikawa@...hiba.co.jp wrote:
>>> + properties:
>>> + endpoint:
>>> + $ref: video-interfaces.yaml#
>>> + additionalProperties: false
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my feedback
>> got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all requested
>> changes or keep discussing them.
>>
>> Thank you.
>
> I'm very sorry that I misunderstood the intent of the last conversion.
> https://lore.kernel.org/all/0aa471ce-da83-172d-d870-1ec7a562baf7@linaro.org/
> I thought "additionalProperties: false" can be used and "xxx:true" should stay.
>
> Let me confirm your intentions:
> - "unevaluatedProperties: false" should be used instead of "additionalProperties: false"
> - All of "xxx: true" should be removed
> Are these two correct understandings?
Ah, true, I missed that. It is indeed fine, apologies.
>
>>
>>> +
>>> + required:
>>> + - clock-noncontinuous
>>> + - link-frequencies
>>> + - remote-endpoint
>>> + - data-lanes
>>
>> Not much improved here. required goes after properties, always. I pointed you
>> last time the file which you should use as an example.
>
> I'll check the overall structure of renesas,rzg2l-csi2.yaml.
This needs to be fixed.
>
>>> +
>>> + properties:
>>> + data-lanes:
>>> + description: VIIF supports 1, 2, 3 or 4 data lanes
>>> + minItems: 1
>>> + items:
>>> + - const: 1
>>> + - const: 2
>>> + - const: 3
>>> + - const: 4
>>> +
>>> + clock-noncontinuous: true
>>
>> Drop
This and further can be ignored.
Best regards,
Krzysztof
Powered by blists - more mailing lists