[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <TYAPR01MB62017DD4EEF22EF91D9FA03892CAA@TYAPR01MB6201.jpnprd01.prod.outlook.com>
Date: Thu, 5 Oct 2023 12:30:13 +0000
From: <yuji2.ishikawa@...hiba.co.jp>
To: <krzysztof.kozlowski@...aro.org>, <hverkuil@...all.nl>,
<laurent.pinchart@...asonboard.com>, <mchehab@...nel.org>,
<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
<conor+dt@...nel.org>, <nobuhiro1.iwamatsu@...hiba.co.jp>
CC: <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add
Toshiba Visconti Video Input Interface
Hello Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, October 4, 2023 3:51 PM
> To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開)
> <yuji2.ishikawa@...hiba.co.jp>; hverkuil@...all.nl;
> laurent.pinchart@...asonboard.com; mchehab@...nel.org;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> iwamatsu nobuhiro(岩松 信洋 ○DITC□DIT○OST)
> <nobuhiro1.iwamatsu@...hiba.co.jp>
> Cc: linux-media@...r.kernel.org; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba
> Visconti Video Input Interface
>
> On 04/10/2023 01:10, yuji2.ishikawa@...hiba.co.jp wrote:
> >>> + properties:
> >>> + endpoint:
> >>> + $ref: video-interfaces.yaml#
> >>> + additionalProperties: false
> >>
> >> This is a friendly reminder during the review process.
> >>
> >> It seems my previous comments were not fully addressed. Maybe my
> >> feedback got lost between the quotes, maybe you just forgot to apply it.
> >> Please go back to the previous discussion and either implement all
> >> requested changes or keep discussing them.
> >>
> >> Thank you.
> >
> > I'm very sorry that I misunderstood the intent of the last conversion.
> > https://lore.kernel.org/all/0aa471ce-da83-172d-d870-1ec7a562baf7@linar
> > o.org/ I thought "additionalProperties: false" can be used and
> > "xxx:true" should stay.
> >
> > Let me confirm your intentions:
> > - "unevaluatedProperties: false" should be used instead of
> "additionalProperties: false"
> > - All of "xxx: true" should be removed Are these two correct
> > understandings?
>
> Ah, true, I missed that. It is indeed fine, apologies.
>
I understand. I'll use "additionalProperties: false".
> >
> >>> +
> >>> + properties:
> >>> + data-lanes:
> >>> + description: VIIF supports 1, 2, 3 or 4 data lanes
> >>> + minItems: 1
> >>> + items:
> >>> + - const: 1
> >>> + - const: 2
> >>> + - const: 3
> >>> + - const: 4
> >>> +
> >>> + clock-noncontinuous: true
> >>
> >> Drop
>
> This and further can be ignored.
I'll keep "xxx: true".
> Best regards,
> Krzysztof
Best regards,
Yuji
Powered by blists - more mailing lists