lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <6929FC3F-06F4-45D1-96D4-0ABF86EA8698@linux.vnet.ibm.com>
Date:   Wed, 4 Oct 2023 13:43:28 +0530
From:   Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
To:     Ian Rogers <irogers@...gle.com>, colin.i.king@...il.com
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        linux-perf-users <linux-perf-users@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] perf: fix spelling mistake "parametrized" ->
 "parameterized"



> On 04-Oct-2023, at 6:37 AM, Ian Rogers <irogers@...gle.com> wrote:
> 
> On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@...il.com> wrote:
>> 
>> There are spelling mistakes in comments and a pr_debug message. Fix them.
>> 
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> + Athira Rajeev
> 
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Reviewed-by: Athira Rajeev <atrajeev@...ux.vnet.ibm.com <mailto:atrajeev@...ux.vnet.ibm.com>>

Thanks
Athira
> 
> Thanks,
> Ian
> 
>> ---
>> tools/perf/tests/parse-events.c        | 4 ++--
>> tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
>> index f78be21a5999..e52f45c7c3d1 100644
>> --- a/tools/perf/tests/parse-events.c
>> +++ b/tools/perf/tests/parse-events.c
>> @@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>>                        if (strchr(ent->d_name, '.'))
>>                                continue;
>> 
>> -                       /* exclude parametrized ones (name contains '?') */
>> +                       /* exclude parameterized ones (name contains '?') */
>>                        n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
>>                        if (n >= PATH_MAX) {
>>                                pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
>> @@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>>                        fclose(file);
>> 
>>                        if (is_event_parameterized == 1) {
>> -                               pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
>> +                               pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
>>                                continue;
>>                        }
>> 
>> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
>> index c77955419173..d2a3506e0d19 100755
>> --- a/tools/perf/tests/shell/stat_all_pmu.sh
>> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
>> @@ -4,7 +4,7 @@
>> 
>> set -e
>> 
>> -# Test all PMU events; however exclude parametrized ones (name contains '?')
>> +# Test all PMU events; however exclude parameterized ones (name contains '?')
>> for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
>>   echo "Testing $p"
>>   result=$(perf stat -e "$p" true 2>&1)
>> --
>> 2.39.2
>> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ