linux-kernel - Re: [PATCH] dt-bindings: mtd: cadence: convert cadence-nand-controller.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Oct 2023 13:32:25 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     "Rabara, Niravkumar L" <niravkumar.l.rabara@...el.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: mtd: cadence: convert
 cadence-nand-controller.txt to yaml

Hello,

> > > -Child nodes represent the available NAND chips.  
> > 
> > This is not fully pictured in the current schema, by referencing nand-
> > controller.yaml I believe you allow all kind of direct partitioning (which is legacy,
> > and not supposed to be supported here).
> > Can you try to define a partition directly within the controller node in the example
> > and see whether it still passes the checks?
> > 
> > Thanks,
> > Miquèl  
> 
> Hi Miquel,
> 
> I tried below in the controller node in example,
> 
>        ...
>         clocks = <&nf_clk>;
>         cdns,board-delay-ps = <4830>;
> 
>         partition@0 {
>           label = "boot";
>           reg = <0 0x00200000>;
>          };
> 
>         nand@0 {
>             reg = <0>;
>         };
> 
> It shows  'partition@0' was unexpected.
> 
> DTC_CHK Documentation/devicetree/bindings/mtd/cadence,nand.example.dtb
> Documentation/devicetree/bindings/mtd/cadence,nand.example.dts:35.23-38.14: Warning (unique_unit_address_if_enabled): /example-0/nand-controller@...80000/partition@0: duplicate unit-address (also used in node /example-0/nand-controller@...80000/nand@0)
> /mnt/newvolume/users/nrabara/kernel.org/3oct23/Documentation/devicetree/bindings/mtd/cadence,nand.example.dtb: nand-controller@...80000: Unevaluated properties are not allowed ('partition@0' was unexpected)
>         From schema: /mnt/newvolume/users/nrabara/kernel.org/3oct23/Documentation/devicetree/bindings/mtd/cadence,nand.yaml
> 
> However using partition in nand node is OK.
>         nand@0 {
>             reg = <0>;
>             
>             #address-cells = <1>;
>             #size-cells = <1>;
> 
>             partition@0 {
>               label = "boot";
>               reg = <0 0x00200000>;
>             };
> 
>             partition@...000 {
>               label = "env";
>               reg = <0x00200000 0x00400000>;
>             };
>         };
> 
> "make dt_binding_check DT_SCHEMA_FILES=mtd/cadence,nand.yaml"  is OK without any warnings. 
> 
> DTEX    Documentation/devicetree/bindings/mtd/cadence,nand.example.dts
> DTC_CHK Documentation/devicetree/bindings/mtd/cadence,nand.example.dtb
> 
> Any additional changes required for this patch?

No, should be fine then.

Thanks,
Miquèl