linux-kernel - Re: [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e0d9d61-43ab-448a-9c28-59b5d710a151@linaro.org>
Date:   Thu, 5 Oct 2023 10:41:46 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Naresh Solanki <naresh.solanki@...ements.com>,
        Rob Herring <robh@...nel.org>
Cc:     broonie@...nel.org, zev@...ilderbeest.net,
        Liam Girdwood <lgirdwood@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple
 supplies

On 05/10/2023 09:46, Naresh Solanki wrote:
> Hi Rob,
> 
> 
> On Wed, 4 Oct 2023 at 20:44, Rob Herring <robh@...nel.org> wrote:
>>
>> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote:
>>> Add support for multiple supplies.
>>
>> Why?
> 1. Driver is already capable of that using platform data. Hence added
> support to read DT property & initialize the same for multiple
> supplies instead of being limited to one.

I am not sure that's a valid reason. Bindings focus on the hardware. We
do not describe here driver capabilities.

> 2. This is particularly useful in cases wherein 2 or more regulators
> are coupled together, for example in a PCIe connector having 3.3V &
> 12V.

Commit message should explain this. Each commit, when not obvious,
should say why you are doing things.

Best regards,
Krzysztof