linux-kernel - Re: [PATCH] ASoC: qcom: reduce number of binding headers includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <688c0678-fad8-490a-9f1e-bb0caffee129@linaro.org>
Date:   Thu, 5 Oct 2023 09:27:03 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Banajit Goswami <bgoswami@...cinc.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: qcom: reduce number of binding headers includes

On 04/10/2023 18:30, Krzysztof Kozlowski wrote:
> Move the includes of binding headers from Qualcomm SoC sound drivers
> headers to unit files actually using these bindings.  This reduces the
> amount of work for C preprocessor and makes usage of bindings easier to
> follow.  No impact expected on final binaries.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  sound/soc/qcom/apq8016_sbc.c            | 1 +
>  sound/soc/qcom/common.c                 | 2 +-
>  sound/soc/qcom/lpass-cdc-dma.c          | 1 +
>  sound/soc/qcom/lpass-cpu.c              | 1 +
>  sound/soc/qcom/lpass-platform.c         | 1 +
>  sound/soc/qcom/lpass.h                  | 1 -
>  sound/soc/qcom/qdsp6/q6afe-clocks.c     | 1 +
>  sound/soc/qcom/qdsp6/q6afe-dai.c        | 1 +
>  sound/soc/qcom/qdsp6/q6afe.c            | 1 +
>  sound/soc/qcom/qdsp6/q6afe.h            | 2 --
>  sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 1 +
>  sound/soc/qcom/qdsp6/q6apm.h            | 1 -
>  sound/soc/qcom/qdsp6/q6asm-dai.c        | 1 +
>  sound/soc/qcom/qdsp6/q6asm.c            | 1 +
>  sound/soc/qcom/qdsp6/q6asm.h            | 1 -
>  sound/soc/qcom/qdsp6/q6prm-clocks.c     | 2 +-
>  sound/soc/qcom/qdsp6/q6routing.c        | 2 ++
>  sound/soc/qcom/sc7180.c                 | 2 +-
>  sound/soc/qcom/sc7280.c                 | 2 ++
>  sound/soc/qcom/sc8280xp.c               | 1 +
>  sound/soc/qcom/sdm845.c                 | 1 +
>  sound/soc/qcom/sdw.c                    | 2 +-
>  sound/soc/qcom/sm8250.c                 | 1 +

I missed few cases of header dependencies, as pointed out by kbuild. I
will send v2.

Best regards,
Krzysztof