linux-kernel - Re: [PATCH] maengine: ste_dma40: Fix PM disable depth imbalance in d40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZtOdBYfHtAE-2QzqhUhELFm38TV93ek7bO1qLJMGiXLA@mail.gmail.com>
Date:   Fri, 6 Oct 2023 22:39:40 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Zhang Shurong <zhang_shurong@...mail.com>
Cc:     vkoul@...nel.org, linux-arm-kernel@...ts.infradead.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] maengine: ste_dma40: Fix PM disable depth imbalance in d40_probe

On Thu, Oct 5, 2023 at 4:28 PM Zhang Shurong <zhang_shurong@...mail.com> wrote:

> The pm_runtime_enable will increase power disable depth. Thus
> a pairing decrement is needed on the error handling path to
> keep it balanced according to context.
> We fix it by calling pm_runtime_disable when error returns.
>
> Signed-off-by: Zhang Shurong <zhang_shurong@...mail.com>

Looks correct,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij