linux-kernel - Re: [PATCH v4] x86/tdx: Dump TDX version During the TD Bootup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2023 20:40:18 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "Sun, Yi" <yi.sun@...el.com>
CC:     "Yan, Dongcheng" <dongcheng.yan@...el.com>,
        "Su, Heng" <heng.su@...el.com>, "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "yi.sun@...ux.intel.com" <yi.sun@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] x86/tdx: Dump TDX version During the TD Bootup

On Fri, 2023-10-06 at 19:09 +0800, Sun, Yi wrote:
> > > +
> > > +	/* TDX 1.0 does not have the TDCALL TDG.SYS.RD */
> > > +version_1_0:
> > > +	td_sys->vendor_id = TDX_VENDOR_INTEL;
> > > +	td_sys->major_version = 1;
> > > +	td_sys->minor_version = 0;
> > 
> > So the main reason that I think you can just print module version in this
> > function instead of tdx_early_init() is because IIUC you are setting up some
> > random value for TDX module 1.0.  Probably it's better to just print it's module
> > 1.0 w/o mentioning major/minor.
> 
> Actually, it is not a random value here; it is the fixed value for TDX 1.0
> becasue there is not such version info in TDX 1.0.
> I assume we can state major=1 and minor=0 when TDX 1.0 is detected.
> This will prevent confusion for the users.

I mean we cannot assume minor always being 0, IIUC.  I am not sure whether we
should report it just as 0.