linux-kernel - Re: [PATCH v5 1/7] drm/msm/dp: tie dp_display_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2023 14:31:27 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Kuogee Hsieh <quic_khsieh@...cinc.com>,
        dri-devel@...ts.freedesktop.org, robdclark@...il.com,
        sean@...rly.run, swboyd@...omium.org, dianders@...omium.org,
        vkoul@...nel.org, daniel@...ll.ch, airlied@...il.com,
        agross@...nel.org, andersson@...nel.org
Cc:     quic_abhinavk@...cinc.com, quic_jesszhan@...cinc.com,
        quic_sbillaka@...cinc.com, marijn.suijten@...ainline.org,
        freedreno@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp
 driver

On 04/10/2023 19:26, Kuogee Hsieh wrote:
> Currently the dp_display_request_irq() is executed at msm_dp_modeset_init()
> which ties irq registering to the DPU device's life cycle, while depending on
> resources that are released as the DP device is torn down. Move register DP
> driver irq handler to dp_display_probe() to have dp_display_irq_handler()
> IRQ tied with DP device. In addition, use platform_get_irq() to retrieve irq
> number from platform device directly.
> 
> Changes in v5:
> -- reworded commit text as review comments at change #4
> -- tear down component if failed at dp_display_request_irq()
> 
> Changes in v4:
> -- delete dp->irq check at dp_display_request_irq()
> 
> Changes in v3:
> -- move calling dp_display_irq_handler() to probe
> 
> Signed-off-by: Kuogee Hsieh <quic_khsieh@...cinc.com>
> ---
>   drivers/gpu/drm/msm/dp/dp_display.c | 32 +++++++++++++-------------------
>   drivers/gpu/drm/msm/dp/dp_display.h |  1 -
>   2 files changed, 13 insertions(+), 20 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>


-- 
With best wishes
Dmitry