linux-kernel - Re: [PATCH] hwrng: geode: fix accessing registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOiHx=nCfU22yd9-KommKMEnKq+VpQROOfKwyb9kbRWzY3azhg@mail.gmail.com>
Date:   Fri, 6 Oct 2023 13:34:04 +0200
From:   Jonas Gorski <jonas.gorski@...il.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Andres Salomon <dilinger@...ued.net>,
        Olivia Mackall <olivia@...enic.com>,
        Xiongfeng Wang <wangxiongfeng2@...wei.com>,
        "Timur I . Davletshin" <timur.davletshin@...il.com>,
        Jo-Philipp Wich <jo@...n.io>, linux-geode@...ts.infradead.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwrng: geode: fix accessing registers

Hi Herbert,

On Fri, 15 Sept 2023 at 12:46, Herbert Xu <herbert@...dor.apana.org.au> wrote:
>
> On Sun, Sep 10, 2023 at 10:34:17AM +0200, Jonas Gorski wrote:
> > When the membase and pci_dev pointer were moved to a new struct in priv,
> > the actual membase users were left untouched, and they started reading
> > out arbitrary memory behind the struct instead of registers. This
> > unfortunately turned the RNG into a constant number generator, depending
> > on the content of what was at that offset.
> >
> > To fix this, update geode_rng_data_{read,present}() to also get the
> > membase via amd_geode_priv, and properly read from the right addresses
> > again.
> >
> > Fixes: 9f6ec8dc574e ("hwrng: geode - Fix PCI device refcount leak")
> > Reported-by: Timur I. Davletshin <timur.davletshin@...il.com>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217882
> > Tested-by: Timur I. Davletshin <timur.davletshin@...il.com>
> > Suggested-by: Jo-Philipp Wich <jo@...n.io>
> > Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>
> > ---
> >  drivers/char/hw_random/geode-rng.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Patch applied.  Thanks.

Where was it applied? I don't see it neither in linus' tree nor in
char-misc. Wondering if it got stuck somewhere.

Best Regards,
Jonas