linux-kernel - Re: [PATCH 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5984411.lOV4Wx5bFT@radijator>
Date:   Fri, 06 Oct 2023 15:08:42 +0200
From:   Duje Mihanović <duje.mihanovic@...le.hr>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Lee Jones <lee@...nel.org>, Jingoo Han <jingoohan1@...il.com>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Helge Deller <deller@....de>, Karel Balej <balejk@...fyz.cz>,
        dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fbdev@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding

On Friday, October 6, 2023 2:30:14 PM CEST Daniel Thompson wrote:
> On Thu, Oct 05, 2023 at 08:49:08PM +0200, Duje Mihanović wrote:
> > +  enable-gpios:
> > +    maxItems: 1
> 
> Why "enable"? This is the line we are going to us to bitbang the
> ExpressWire protocol. Doesn't that make it a control or data pin?

I named it "enable" because the KTD253 driver does so too, but also because 
that pin is also used to power down the IC. If "enable" isn't right 
regardless, is just "gpios" fine for this?

Regards,
Duje