linux-kernel - Re: [PATCH 2/2] backlight: Add Kinetic KTD2801 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2306278.ElGaqSPkdT@radijator>
Date:   Fri, 06 Oct 2023 15:11:58 +0200
From:   Duje Mihanović <duje.mihanovic@...le.hr>
To:     Lee Jones <lee@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Helge Deller <deller@....de>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Karel Balej <balejk@...fyz.cz>, dri-devel@...ts.freedesktop.org,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/2] backlight: Add Kinetic KTD2801 driver

On Thursday, October 5, 2023 10:40:41 PM CEST Krzysztof Kozlowski wrote:
> On 05/10/2023 20:49, Duje Mihanović wrote:
> > +	gpiod_set_value(ktd2801->desc, 0);
> > +	udelay(EOD_H);
> 
> Hm, why device is kept off after this? Setting 0 means enable GPIO is
> logical 0.
...
> > +	ktd2801->desc = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
> 
> OUT_LOW is keep it disabled, so is this intentional?

I initially wrote the driver to expect GPIO_ACTIVE_LOW, a decision which in 
retrospect indeed makes no sense. If you have no objections, I'll change it to 
expect GPIO_ACTIVE_HIGH.

Regards,
Duje