[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231006145332.8739-1-hgajjar@de.adit-jv.com>
Date: Fri, 6 Oct 2023 16:53:32 +0200
From: Hardik Gajjar <hgajjar@...adit-jv.com>
To: <gregkh@...uxfoundation.org>, <s.hauer@...gutronix.de>,
<jonathanh@...dia.com>, <linux-usb@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: <quic_linyyuan@...cinc.com>, <paul@...pouillou.net>,
<quic_eserrao@...cinc.com>, <erosca@...adit-jv.com>,
<hgajjar@...adit-jv.com>
Subject: [PATCH v2] usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach
This patch replaces the usage of netif_stop_queue with netif_device_detach
in the u_ether driver. The netif_device_detach function not only stops all
tx queues by calling netif_tx_stop_all_queues but also marks the device as
removed by clearing the __LINK_STATE_PRESENT bit.
This change helps notify user space about the disconnection of the device
more effectively, compared to netif_stop_queue, which only stops a single
transmit queue.
Changes since version 1:
- Correct Singed-off user name and e-mail
Signed-off-by: Hardik Gajjar <hgajjar@...adit-jv.com>
---
drivers/usb/gadget/function/u_ether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 4bb0553da658..b0daee35b996 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -635,7 +635,7 @@ static int eth_stop(struct net_device *net)
unsigned long flags;
VDBG(dev, "%s\n", __func__);
- netif_stop_queue(net);
+ netif_device_detach(dev->net);
DBG(dev, "stop stats: rx/tx %ld/%ld, errs %ld/%ld\n",
dev->net->stats.rx_packets, dev->net->stats.tx_packets,
--
2.17.1
Powered by blists - more mailing lists