linux-kernel - Re: [PATCH v2] usb: gadget: u_ether: Replace netif_stop_queue with netif_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2023 16:59:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Hardik Gajjar <hgajjar@...adit-jv.com>
Cc:     s.hauer@...gutronix.de, jonathanh@...dia.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_linyyuan@...cinc.com, paul@...pouillou.net,
        quic_eserrao@...cinc.com, erosca@...adit-jv.com
Subject: Re: [PATCH v2] usb: gadget: u_ether: Replace netif_stop_queue with
 netif_device_detach

On Fri, Oct 06, 2023 at 04:53:32PM +0200, Hardik Gajjar wrote:
> This patch replaces the usage of netif_stop_queue with netif_device_detach
> in the u_ether driver. The netif_device_detach function not only stops all
> tx queues by calling netif_tx_stop_all_queues but also marks the device as
> removed by clearing the __LINK_STATE_PRESENT bit.
> 
> This change helps notify user space about the disconnection of the device
> more effectively, compared to netif_stop_queue, which only stops a single
> transmit queue.
> 
> Changes since version 1:
> 	- Correct Singed-off user name and e-mail

Nit, this goes below the --- line :(