[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=Ua-bDMvSj-FRWKxCm3oS4U-rqzd--g4UX_TBDF65rb5A@mail.gmail.com>
Date: Fri, 6 Oct 2023 12:14:03 -0700
From: Doug Anderson <dianders@...omium.org>
To: Vijaya Krishna Nivarthi <quic_vnivarth@...cinc.com>
Cc: agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
broonie@...nel.org, linux-arm-msm@...r.kernel.org,
linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
quic_msavaliy@...cinc.com, mka@...omium.org, swboyd@...omium.org,
quic_vtanuku@...cinc.com
Subject: Re: [PATCH] spi: spi-geni-qcom: Rename the label unmap_if_dma
Hi,
On Fri, Oct 6, 2023 at 10:43 AM Vijaya Krishna Nivarthi
<quic_vnivarth@...cinc.com> wrote:
>
> The code at unmap_if_dma label doesn't contain unmapping dma anymore but
> has only fsm reset.
>
> Rename it to reset_if_dma accordingly.
>
> No functional change.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@...cinc.com>
> ---
> drivers/spi/spi-geni-qcom.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I guess perhaps technically this could have:
Fixes: 3a76c7ca9e77 ("spi: spi-geni-qcom: Do not do DMA map/unmap
inside driver, use framework instead")
...since before that commit it _did_ do the unmap, right? ;-)
In any case, this seems good to me:
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists