linux-kernel - Re: [PATCH] watchdog: wdat_wdt: Add timeout value as a param in ping method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3767ca06-2c66-4f7d-84d8-8e77b1ab87e1@roeck-us.net>
Date:   Sat, 7 Oct 2023 06:34:26 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Xing Tong Wu <xingtong_wu@....com>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        xingtong.wu@...mens.com, jan.kiszka@...mens.com,
        tobias.schaffner@...mens.com, cedric.hombourger@...mens.com,
        gerd.haeussler.ext@...mens.com
Subject: Re: [PATCH] watchdog: wdat_wdt: Add timeout value as a param in ping
 method

On Sat, Oct 07, 2023 at 04:21:25PM +0800, Xing Tong Wu wrote:
> From: Xing Tong Wu <xingtong.wu@...mens.com>
> 
> According to the WDAT spec that states about WATCHDOG_ACTION_SET_COUNTDOWN_PERIOD:
> "This action is required if WATCHDOG_ACTION_RESET does not explicitly write a new
> countdown value to a register during a reset."
> And that implies, WATCHDOG_ACTION_RESET may write a countdown value, thus may come
> with a WATCHDOG_INSTRUCTION_WRITE_COUNTDOWN, thus need the timeout value as parameter
> or would otherwise write 0.
> The watchdog for SIONCT6126 need a entry WATCHDOG_INSTRUCTION_WRITE_COUNTDOWN for
> WATCHDOG_ACTION_RESET action, I send this patch to support it.
> 
> Signed-off-by: Xing Tong Wu <xingtong.wu@...mens.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/wdat_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c
> index 0ba99bed59fc..650fdc7996e1 100644
> --- a/drivers/watchdog/wdat_wdt.c
> +++ b/drivers/watchdog/wdat_wdt.c
> @@ -269,7 +269,7 @@ static int wdat_wdt_stop(struct watchdog_device *wdd)
>  
>  static int wdat_wdt_ping(struct watchdog_device *wdd)
>  {
> -	return wdat_wdt_run_action(to_wdat_wdt(wdd), ACPI_WDAT_RESET, 0, NULL);
> +	return wdat_wdt_run_action(to_wdat_wdt(wdd), ACPI_WDAT_RESET, wdd->timeout, NULL);
>  }
>  
>  static int wdat_wdt_set_timeout(struct watchdog_device *wdd,
> -- 
> 2.25.1
>