[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231008174745.27342-1-ghandatmanas@gmail.com>
Date: Sun, 8 Oct 2023 23:17:45 +0530
From: Manas Ghandat <ghandatmanas@...il.com>
To: dave.kleikamp@...cle.com, shaggy@...nel.org
Cc: Manas Ghandat <ghandatmanas@...il.com>,
Linux-kernel-mentees@...ts.linuxfoundation.org,
jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
syzbot+c1056fdfe414463fdb33@...kaller.appspotmail.com
Subject: [PATCH] jfs : fix array-index-out-of-bounds in diWrite
Currently while copying dtree root from inode to dnode in the xp slot
there is a out of bound memcpy. Added a bound check to the memcpy.
Reported-by: syzbot+c1056fdfe414463fdb33@...kaller.appspotmail.com
Fixes: https://syzkaller.appspot.com/bug?extid=c1056fdfe414463fdb33
Signed-off-by: Manas Ghandat <ghandatmanas@...il.com>
---
fs/jfs/jfs_imap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/jfs/jfs_imap.c b/fs/jfs/jfs_imap.c
index 799d3837e7c2..d1f897848be0 100644
--- a/fs/jfs/jfs_imap.c
+++ b/fs/jfs/jfs_imap.c
@@ -746,7 +746,8 @@ int diWrite(tid_t tid, struct inode *ip)
xp = (dtpage_t *) & dp->di_dtroot;
lv = ilinelock->lv;
for (n = 0; n < ilinelock->index; n++, lv++) {
- memcpy(&xp->slot[lv->offset], &p->slot[lv->offset],
+ if (lv->offset < 128)
+ memcpy(&xp->slot[lv->offset], &p->slot[lv->offset],
lv->length << L2DTSLOTSIZE);
}
} else {
--
2.37.2
Powered by blists - more mailing lists