linux-kernel - Re: [PATCH 3/4] mm: abstract merge for new VMAs into vma_merge_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0300e5a-394d-0cdf-4044-a9a67a24c9b3@suse.cz>
Date:   Mon, 9 Oct 2023 18:04:47 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Lorenzo Stoakes <lstoakes@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>
Cc:     "=Liam R . Howlett" <Liam.Howlett@...cle.com>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 3/4] mm: abstract merge for new VMAs into
 vma_merge_new_vma()

On 10/8/23 22:23, Lorenzo Stoakes wrote:
> Only in mmap_region() and copy_vma() do we add VMAs which occupy entirely
> new regions of virtual memory.
> 
> We can share the logic between these invocations and make it absolutely
> explici to reduce confusion around the rather inscrutible parameters

explicit ... inscrutable

> possessed by vma_merge().
> 
> This also paves the way for a simplification of the core vma_merge()
> implementation, as we seek to make the function entirely an implementation
> detail.
> 
> Note that on mmap_region(), vma fields are initialised to zero, so we can
> simply reference these rather than explicitly specifying NULL.

Right, if they were different from NULL, the code would be broken already.

> Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>