linux-kernel - Re: [PATCH 2/4] mm: make vma_merge() and split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz>
Date:   Mon, 9 Oct 2023 17:45:26 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Lorenzo Stoakes <lstoakes@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>
Cc:     "=Liam R . Howlett" <Liam.Howlett@...cle.com>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal

On 10/8/23 22:23, Lorenzo Stoakes wrote:
> Now the vma_merge()/split_vma() pattern has been abstracted, we use it

"it" refers to split_vma() only so "the latter" or "split_vma()"?

> entirely internally within mm/mmap.c, so make the function static. We also
> no longer need vma_merge() anywhere else except mm/mremap.c, so make it
> internal.
> 
> In addition, the split_vma() nommu variant also need not be exported.
> 
> Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>