linux-kernel - Re: [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75446d81-449d-b8c9-3e1c-2d9ef8d61e28@raptorengineering.com>
Date:   Mon, 9 Oct 2023 16:04:05 -0500
From:   Shawn Anastasio <sanastasio@...torengineering.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        devicetree@...r.kernel.org, lee@...nel.org,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Timothy Pearson <tpearson@...torengineering.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT
 binding

On 10/3/23 4:22 AM, Krzysztof Kozlowski wrote:
> On 03/10/2023 00:32, Shawn Anastasio wrote:
>> The SIE Cronos Platform Controller CPLD is a multi-purpose platform
> 
> What is SIE? Vendor prefix says sony.
>

(Repeated from my response to your reply to patch 1)
Sony Interactive Entertainment is a separate corporate entity and it's
the one that created the hardware to which this driver pertains.

> What is Cronos?
>

Sorry, I'll amend the description to clarify this. Cronos is an x86
server platform developed and deployed by SIE.

> 
>> controller that provides both a watchdog timer and an LED controller. As
>> both functions are provided by the same CPLD, a multi-function device is
>> exposed as the parent of both functions.
> 
> A nit, subject: drop second/last, redundant "DT binding". The
> "dt-bindings" prefix is already stating that these are bindings.
>

Will do.

>>
>> Add a DT binding for this device.
>>
>> Signed-off-by: Shawn Anastasio <sanastasio@...torengineering.com>
> 
> Except that this was clearly no tested...
> 

My apologies, it seems I didn't have all of the required dependencies
installed locally to enable dt binding validation. Will fix.

>> ---
> 
> ...
> 
>> +properties:
>> +  compatible:
>> +    const: sie,cronos-cpld
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  '#address-cells':
>> +    const: 1
> 
> Why do you need it?
>
>> +
>> +  '#size-cells':
>> +    const: 1
> 
> Also looks unneeded.
>

These were inherited from an existing dt binding in the tree that I used
as a reference. I'll drop them both at your request.

>> +
>> +  leds:
>> +    type: object
>> +    description: Cronos Platform Status LEDs
> 
> Missing additionalProperties:false... but anyway this is just empty. No
> resources? Drop the node.
>

Having nodes for the leds and the watchdog allows the two independent
functions to be enabled/disabled in the device tree by adding/removing
the relevant object. Would it be more idiomatic to instead introduce
properties to the parent sie,cronos-cpld object to toggle these
functions?

>> +
>> +    properties:
>> +      compatible:
>> +        const: sie,cronos-leds
>> +
>> +  watchdog:
>> +    type: object
>> +    description: Cronos Platform Watchdog Timer
>> +
>> +    properties:
>> +      compatible:
>> +        const: sie,cronos-watchdog
> 
> No resources? Drop the node.
> 

Same question as above.

> Best regards,
> Krzysztof

Thanks,
Shawn