linux-kernel - Re: [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <732e0da8-0eff-41c2-bfea-b27a708cf8f6@linaro.org>
Date:   Wed, 11 Oct 2023 20:39:52 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shawn Anastasio <sanastasio@...torengineering.com>,
        devicetree@...r.kernel.org, lee@...nel.org,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Timothy Pearson <tpearson@...torengineering.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT
 binding

On 09/10/2023 23:04, Shawn Anastasio wrote:
>>> +
>>> +  leds:
>>> +    type: object
>>> +    description: Cronos Platform Status LEDs
>>
>> Missing additionalProperties:false... but anyway this is just empty. No
>> resources? Drop the node.
>>
> 
> Having nodes for the leds and the watchdog allows the two independent
> functions to be enabled/disabled in the device tree by adding/removing
> the relevant object. Would it be more idiomatic to instead introduce
> properties to the parent sie,cronos-cpld object to toggle these
> functions?

And why DT should be used to enable/disable them? Or are you suggesting
you have different devices under the same compatible?



Best regards,
Krzysztof