linux-kernel - Re: [PATCH] um: vector: fix return value check in vector_mmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff46c71a7eb6c43c9e06e99d30bdcb1f8152ee7e.camel@sipsolutions.net>
Date:   Mon, 09 Oct 2023 09:31:53 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Ma Ke <make_ruc2021@....com>, richard@....at,
        anton.ivanov@...bridgegreys.com, xiangyang3@...wei.com
Cc:     linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: vector: fix return value check in vector_mmsg_rx

On Sat, 2023-10-07 at 08:51 +0800, Ma Ke wrote:
> In vector_mmsg_rx, to avoid an unexpected result returned by
> pskb_trim, we should check the return value of pskb_trim().

And how exactly do you propose pskb_trim() will return anything but 0 in
this scenario?

Please. If you have a static checker, _think_ about it's output before
blindly sending patches.

johannes