linux-kernel - RE: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool frag allocation failure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR1801MB1918D28C8C01344D1CC3F638D3CEA@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date:   Mon, 9 Oct 2023 09:47:09 +0000
From:   Ratheesh Kannoth <rkannoth@...vell.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "alexander.duyck@...il.com" <alexander.duyck@...il.com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "bigeasy@...utronix.de" <bigeasy@...utronix.de>
Subject: RE: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool frag
 allocation failure.

> From: Yunsheng Lin <linyunsheng@...wei.com>
> Subject: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool frag allocation
> failure.


> interface is configured with higher rx buffer size?
>                         ^^^^
What is the issue here ?  English ?


> > +	sz = ALIGN(SKB_DATA_ALIGN(buf_size), OTX2_ALIGN);
> 
> Is the above really needed if PAGE_SIZE is bigger than SMP_CACHE_BYTES or
> OTX2_ALIGN? Doesn't get_order() already ensure that the alignment is
> bigger than SMP_CACHE_BYTES or OTX2_ALIGN?
Yes. It will  ensure with current values.  But being  OXT2_ALIGN and SK_DATA_ALIGN are macros, why don’t we 
Ensure the alignment, using the ALIGN().  

-Ratheesh