linux-kernel - Re: [PATCH v1] samples: kprobes: Fixes a typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231011180408.GB51067@atom0118>
Date:   Wed, 11 Oct 2023 23:34:08 +0530
From:   Atul Kumar Pant <atulpant.linux@...il.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>, naveen.n.rao@...ux.ibm.com,
        anil.s.keshavamurthy@...el.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org, shuah@...nel.org
Subject: Re: [PATCH v1] samples: kprobes: Fixes a typo

On Tue, Oct 10, 2023 at 12:03:56AM +0900, Masami Hiramatsu wrote:
> On Mon, 9 Oct 2023 09:51:03 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > On Sat, 7 Oct 2023 21:09:00 +0530
> > Atul Kumar Pant <atulpant.linux@...il.com> wrote:
> > 
> > > On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > > > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:  
> > > > > Fixes typo in a function name.
> > > > > 
> > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@...il.com>
> > > > > ---
> > > > >  samples/kprobes/kretprobe_example.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > > > index cbf16542d84e..ed79fd3d48fb 100644
> > > > > --- a/samples/kprobes/kretprobe_example.c
> > > > > +++ b/samples/kprobes/kretprobe_example.c
> > > > > @@ -35,7 +35,7 @@ struct my_data {
> > > > >  	ktime_t entry_stamp;
> > > > >  };
> > > > >  
> > > > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > > > +/* Here we use the entry_handler to timestamp function entry */
> > > > >  static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > > >  {
> > > > >  	struct my_data *data;
> > > > > -- 
> > > > > 2.25.1
> > > > >   
> > > > 
> > > > 	Hi all, can someone provide comments on this change.  
> > > 
> > > 			Hi all, can someone please review this change. It has been not
> > > 			reviewed for quite some time.
> > 
> > That's because trivial typos in comments are considered very low priority,
> > and are usually only added (if they are ever added) if the maintainer has
> > extra time, which may not be for a while.
> 
> Anyway, let me pick this. I found this in my inbox now. :)

	Thank you. Sorry for the redundant emails for reviewing the change :)
> 
> Thank you,
> 
> > 
> > -- Steve
> 
> 
> -- 
> Masami Hiramatsu (Google) <mhiramat@...nel.org>