lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMknhBEzbeUgQweKk7+tmwRTA4XpkMdEHQO+UFRLrcFvQaOf8w@mail.gmail.com>
Date:   Thu, 12 Oct 2023 11:23:11 -0500
From:   David Lechner <dlechner@...libre.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Axel Haslam <ahaslam@...libre.com>,
        Philip Molloy <pmolloy@...libre.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/4] iio: resolver: ad2s1210: move out of staging

On Thu, Oct 12, 2023 at 3:25 AM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Tue, 10 Oct 2023 16:12:36 -0500
> David Lechner <dlechner@...libre.com> wrote:
>
> > This moves the ad2s1210 resolver driver out of staging. The driver has
> > been fixed up and is ready to graduate.
> >
> > Signed-off-by: David Lechner <dlechner@...libre.com>
> > ---
> >
> > v5 changes: New patch in v5.
> >
> > Diff was made with file rename detection turned off so we can see the full
> > driver code for one last check through. sysfs-bus-iio-resolver-ad2s1210 and
> > ad2s1210.c are just moved (no changes).
>
> Excellent.  Great work btw - this looks really nice now.
>
> I did a final scan through (most of the code was familiar for some reason :)

Thanks for all of the reviews. There were less than 200 lines left
(mostly blank lines and boilerplate) that didn't get touched!

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ