lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ABAC8D80-D7E7-4C87-94D3-8D92CFF06E21@meta.com>
Date:   Thu, 12 Oct 2023 16:24:10 +0000
From:   Nick Terrell <terrelln@...a.com>
To:     "pangzizhen001@...suo.com" <pangzizhen001@...suo.com>
CC:     Nick Terrell <terrelln@...a.com>, Nick Terrell <terrelln@...a.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] zstd/decompress: Fix typos in comments



> On Jul 20, 2023, at 11:34 AM, pangzizhen001@...suo.com wrote:
> 
> !-------------------------------------------------------------------|
> This Message Is From an External Sender
> 
> |-------------------------------------------------------------------!
> 
> Delete duplicate word "the"

Please submit this patch upstream to https://github.com/facebook/zstd if you would like to see it merged.

Thanks,
Nick Terrell

> Signed-off-by: Zizhen Pang <pangzizhen001@...suo.com>
> ---
> lib/zstd/decompress/zstd_decompress_block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/zstd/decompress/zstd_decompress_block.c b/lib/zstd/decompress/zstd_decompress_block.c
> index c1913b8e7c89..cd2e9acecd84 100644
> --- a/lib/zstd/decompress/zstd_decompress_block.c
> +++ b/lib/zstd/decompress/zstd_decompress_block.c
> @@ -510,7 +510,7 @@ void ZSTD_buildFSETable_body(ZSTD_seqSymbol* dt,
>             }
>         }
>         /* Now we spread those positions across the table.
> -         * The benefit of doing it in two stages is that we avoid the the
> +         * The benefit of doing it in two stages is that we avoid the
>          * variable size inner loop, which caused lots of branch misses.
>          * Now we can run through all the positions without any branch misses.
>          * We unroll the loop twice, since that is what emperically worked best.


Download attachment "winmail.dat" of type "application/ms-tnef" (13443 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ