linux-kernel - Re: [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADFiAc+67wdcS5enobbty-_U9SGX9Mr-C_0ipU_KJAV+h-t_Tg@mail.gmail.com>
Date:   Thu, 12 Oct 2023 10:08:00 +0900
From:   takeru hayasaka <hayatake396@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: ice: Support for RSS settings to GTP
 from ethtool

> I think we should expose TEID as a field. It's easier to understand
> the API if fields are all listed, and not implied by the flow hash.

Jakub san Thank you for your feedback!
I would like to make changes and send them as a patch for the next version.

2023年10月12日(木) 1:41 Jakub Kicinski <kuba@...nel.org>:
>
> On Wed, 11 Oct 2023 14:25:55 +0900 takeru hayasaka wrote:
> > > Regarding the patch - you are only adding flow types, not a new field
> > > (which are defined as RXH_*). If we want to hash on an extra field,
> > > I think we need to specify that field as well?
> >
> > I've been really struggling with this...
> > When I read the Intel ICE documentation, it suggests that in RSS, TEID
> > can be an additional input.
> > However, I couldn't think of a reason not to include TEID when
> > enabling RSS for GTP cases.
> >
> > https://www.intel.com/content/www/us/en/content-details/617015/intel-ethernet-controller-e810-dynamic-device-personalization-ddp-technology-guide.html
> > (cf. Table 8. Patterns and Input Sets for iavf RSS)
> >
> > However, for Flow Director, it's clear that you'd want to include the
> > TEID field. But since I found that someone from Intel has already
> > configured it to use TEID with Flow Director, I thought maybe we don't
> > need to add the TEID parameter for now.
> >
> > https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20210126065206.137422-1-haiyue.wang@intel.com/
> >
> > If we want to include something other than TEID (e.g., QFI) in Flow
> > Director, I think it would be better to prepare a new field.
>
> I think we should expose TEID as a field. It's easier to understand
> the API if fields are all listed, and not implied by the flow hash.