[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <169709543435.3961410.18389221947480753316.robh@kernel.org>
Date: Thu, 12 Oct 2023 02:23:54 -0500
From: Rob Herring <robh@...nel.org>
To: Javier Martinez Canillas <javierm@...hat.com>
Cc: Peter Robinson <pbrobinson@...il.com>,
linux-kernel@...r.kernel.org, Conor Dooley <conor@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
David Airlie <airlied@...il.com>, devicetree@...r.kernel.org,
Maxime Ripard <mripard@...nel.org>
Subject: Re: [PATCH v2 5/6] dt-bindings: display: Split common Solomon
properties in their own schema
On Thu, 12 Oct 2023 08:58:14 +0200, Javier Martinez Canillas wrote:
> There are DT properties that can be shared across different Solomon OLED
> Display Controller families. Split them into a separate common schema to
> avoid these properties to be duplicated in different DT bindings schemas.
>
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
>
> (no changes since v1)
>
> .../bindings/display/solomon,ssd-common.yaml | 42 +++++++++++++++++++
> .../bindings/display/solomon,ssd1307fb.yaml | 28 +------------
> MAINTAINERS | 1 +
> 3 files changed, 44 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd-common.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/display/solomon,ssd-common.yaml:42:27: [error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231012065822.1007930-6-javierm@redhat.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists