linux-kernel - Re: [PATCH 3/5] parisc: remove broken vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d886d83a-87b4-428d-856e-9bbaa554563a@gmx.de>
Date:   Thu, 12 Oct 2023 09:24:36 +0200
From:   Helge Deller <deller@....de>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-csky@...r.kernel.org, linux-parisc@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-um@...ts.infradead.org, loongarch@...ts.linux.dev,
        sparclinux@...r.kernel.org, x86@...nel.org,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH 3/5] parisc: remove broken vdso_install

Hi Masahiro,

On 10/9/23 14:42, Masahiro Yamada wrote:
> 'make ARCH=parisc vdso_install' has never worked. It attempts to
> descend into arch/parisc/kernel/vdso/, which does not exist.
>
> The command just fails:
>
>    scripts/Makefile.build:41: arch/parisc/kernel/vdso/Makefile: No such file or directory
>
> The second line is also meaningless because parisc does not define
> CONFIG_COMPAT_VDSO.
>
> It appears that this code was copied from another architecture without
> proper adaptation.

Yes.

> Remove the broken code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Thanks for cleaning this up and making it consistent across the architectures.

Acked-by: Helge Deller <deller@....de>  # parisc

In case you do a v2 version of the patch, would you add to arch/parisc/Makefile
(otherwise I can send a follow-up patch in the parisc git tree):

vdso-install-y               += arch/parisc/kernel/vdso32/vdso32.so
vdso-install-$(CONFIG_64BIT) += arch/parisc/kernel/vdso64/vdso64.so

Thanks!
Helge