linux-kernel - Re: [PATCH 2/2] MIPS: lantic: Remove unnecessary include of <linux/of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529023a8-1c13-beb4-8c71-0b3e4ada24f1@linaro.org>
Date:   Thu, 12 Oct 2023 10:27:13 +0200
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 2/2] MIPS: lantic: Remove unnecessary include of
 <linux/of_irq.h>

On 10/10/23 16:34, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> arch/mips/pci/fixup-lantiq.c requires nothing from <linux/of_irq.h>, so
> remove the include of it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
>   arch/mips/pci/fixup-lantiq.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c
> index 8f5fb98b3984..13009666204f 100644
> --- a/arch/mips/pci/fixup-lantiq.c
> +++ b/arch/mips/pci/fixup-lantiq.c
> @@ -4,7 +4,6 @@
>    *  Copyright (C) 2012 John Crispin <john@...ozen.org>
>    */
>   
> -#include <linux/of_irq.h>
>   #include <linux/of_pci.h>

Indeed, we are good with <linux/of_pci.h>.

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>