linux-kernel - Re: [PATCH 1/2] MIPS: lantic: Fix pcibios_plat_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4167ddd-f30a-ba4e-c205-3eab53f02b9a@linaro.org>
Date:   Thu, 12 Oct 2023 10:26:03 +0200
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] MIPS: lantic: Fix pcibios_plat_dev_init() "no
 previous prototype" warning

On 10/10/23 16:34, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> After bbd8810d3998 ("PCI: Remove unused includes and superfluous struct
> declaration"), <linux/of_pci.h> no longer includes <linux/pci.h>, which
> provides the extern declarations for pcibios_plat_dev_init() and
> pcibios_map_irq() via <asm/pci.h>.
> 
> This results in these new warnings:
> 
>    arch/mips/pci/fixup-lantiq.c:13:5: warning: no previous prototype for 'pcibios_plat_dev_init' [-Wmissing-prototypes]
>    arch/mips/pci/fixup-lantiq.c:24:5: warning: no previous prototype for 'pcibios_map_irq' [-Wmissing-prototypes]
> 
> Include <linux/pci.h> directly to get these declarations.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310070445.tzRBNYRC-lkp@intel.com/
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
>   arch/mips/pci/fixup-lantiq.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>