linux-kernel - Re: [PATCH] lib/test_meminit: fix off-by-one error in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=X-dnc06r0Yik24jBaL-f7ZzrUQiUJmMHeN9CaSa3ZveQ@mail.gmail.com>
Date:   Thu, 12 Oct 2023 10:40:14 +0200
From:   Alexander Potapenko <glider@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Andrew Donnellan <ajd@...ux.ibm.com>,
        Xiaoke Wang <xkernel.wang@...mail.com>, stable@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] lib/test_meminit: fix off-by-one error in test_pages()

On Thu, Oct 12, 2023 at 10:17 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> In commit efb78fa86e95 ("lib/test_meminit: allocate pages up to order
> MAX_ORDER"), the loop for testing pages is set to "<= MAX_ORDER" which
> causes crashes in systems when run.  Fix this to "< MAX_ORDER" to fix
> the test to work properly.

What are the crashes you are seeing? Are those OOMs?
IIUC it should be valid to allocate with MAX_ORDER.