[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023101201-grasp-smartly-2085@gregkh>
Date: Thu, 12 Oct 2023 12:26:58 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alexander Potapenko <glider@...gle.com>
Cc: linux-kernel@...r.kernel.org, Andrew Donnellan <ajd@...ux.ibm.com>,
Xiaoke Wang <xkernel.wang@...mail.com>, stable@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] lib/test_meminit: fix off-by-one error in test_pages()
On Thu, Oct 12, 2023 at 10:40:14AM +0200, Alexander Potapenko wrote:
> On Thu, Oct 12, 2023 at 10:17 AM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > In commit efb78fa86e95 ("lib/test_meminit: allocate pages up to order
> > MAX_ORDER"), the loop for testing pages is set to "<= MAX_ORDER" which
> > causes crashes in systems when run. Fix this to "< MAX_ORDER" to fix
> > the test to work properly.
>
> What are the crashes you are seeing? Are those OOMs?
They are WARN_ON() triggers. They are burried in the Android build
system, let me see if I can uncover them.
> IIUC it should be valid to allocate with MAX_ORDER.
"should", but I no longer get runtime warnings with this patch applied,
so something is wrong :)
Let me go dig for the logs again...
Powered by blists - more mailing lists