linux-kernel - Re: [PATCH] mfd: Use device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231012092618.GF8314@google.com>
Date:   Thu, 12 Oct 2023 10:26:18 +0100
From:   Lee Jones <lee@...nel.org>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Rob Herring <robh@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] mfd: Use device_get_match_data()

On Tue, 10 Oct 2023, Chen-Yu Tsai wrote:

> On Tue, Oct 10, 2023 at 5:14 AM Rob Herring <robh@...nel.org> wrote:
> >
> > Use preferred device_get_match_data() instead of of_match_device() to
> > get the driver match data. With this, adjust the includes to explicitly
> > include the correct headers.
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> >  drivers/mfd/axp20x.c           | 22 +++-------------------
> 
> I'd keep the error message, but otherwise for axp20x,
> 
> Reviewed-by: Chen-Yu Tsai <wens@...e.org>
> 
> >  drivers/mfd/hi6421-pmic-core.c |  9 +++------
> >  drivers/mfd/mxs-lradc.c        |  9 ++-------
> >  drivers/mfd/qcom-spmi-pmic.c   |  6 ++++--
> >  drivers/mfd/qcom_rpm.c         |  8 ++++----
> >  drivers/mfd/tps65910.c         | 11 ++---------
> >  drivers/mfd/twl4030-power.c    |  9 +++------
> >  drivers/mfd/twl6030-irq.c      | 10 +++++-----
> >  8 files changed, 26 insertions(+), 58 deletions(-)

FYI, this patch is not in my inbox.

-- 
Lee Jones [李琼斯]