linux-kernel - Re: [PATCH v3] memblock: don't run loop in memblock_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2023 12:24:42 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] memblock: don't run loop in memblock_add_range() twice

On Thu, Oct 05, 2023 at 11:20:19PM +0800, Yajun Deng wrote:
> 
> On 2023/10/5 13:19, Mike Rapoport wrote:
> 
> > I don't see this micro-optimization is worth the churn and potential bugs.
> > NAK.
> 
> There are many handouts that tell people it needs to run twice in
> memblock_add_range().
> 
> I think it's time to change this. I'm trying to tell people that running
> twice is unnecessary.

It might be unnecessary, but it's still simpler than the solutions you
proposed. And, again, removing the second loop is not worth the churn and
potential bugs.
 
-- 
Sincerely yours,
Mike.