linux-kernel - Re: [PATCH] mtd: spi-nor: Ensure operation completion before shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mafs034ygm9yc.fsf@kernel.org>
Date:   Thu, 12 Oct 2023 12:06:19 +0200
From:   Pratyush Yadav <pratyush@...nel.org>
To:     Michael Walle <michael@...le.cc>
Cc:     Md Sadre Alam <quic_mdalam@...cinc.com>, tudor.ambarus@...aro.org,
        pratyush@...nel.org, miquel.raynal@...tlin.com, richard@....at,
        vigneshr@...com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, quic_srichara@...cinc.com,
        quic_varada@...cinc.com
Subject: Re: [PATCH] mtd: spi-nor: Ensure operation completion before shutdown

On Thu, Oct 12 2023, Michael Walle wrote:

> Hi,
>
> Am 2023-10-12 07:51, schrieb Md Sadre Alam:
>> Ensure that there are no pending spi operation inprogress
>> when system halts.
>
> What operation might be in progress here? Did you encounter some problems?
> Please explain it in more detail in the commit message.

+1

Ideally we should never reach this function with a pending operation. I
think we should do a proper wait in the place we did the operation that
needs waiting rather than here. That would make sure operations other
than shutdown, like reads, also work properly.

-- 
Regards,
Pratyush Yadav