linux-kernel - Re: [PATCH] mtd: spi-nor: Ensure operation completion before shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c489e1d8-e621-df30-f424-b6dfaddbd6b7@quicinc.com>
Date:   Wed, 18 Oct 2023 16:36:33 +0530
From:   Md Sadre Alam <quic_mdalam@...cinc.com>
To:     Michael Walle <michael@...le.cc>
CC:     <tudor.ambarus@...aro.org>, <pratyush@...nel.org>,
        <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH] mtd: spi-nor: Ensure operation completion before shutdown



On 10/12/2023 2:41 PM, Michael Walle wrote:
> Hi,
> 
> Am 2023-10-12 07:51, schrieb Md Sadre Alam:
>> Ensure that there are no pending spi operation inprogress
>> when system halts.
> 
> What operation might be in progress here? Did you encounter some problems?
> Please explain it in more detail in the commit message.
> 
> Fixes tag?

   We have faced issue while doing nor flash read/write test with specific nor part.
   Will check once again with the same part and post new patch.
> 
> -michael
> 
>> Signed-off-by: Md Sadre Alam <quic_mdalam@...cinc.com>
>> ---
>>  drivers/mtd/spi-nor/core.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
>> index 1c443fe568cf..adc4d2c68695 100644
>> --- a/drivers/mtd/spi-nor/core.c
>> +++ b/drivers/mtd/spi-nor/core.c
>> @@ -3690,6 +3690,9 @@ static void spi_nor_shutdown(struct spi_mem *spimem)
>>  {
>>      struct spi_nor *nor = spi_mem_get_drvdata(spimem);
>>
>> +    /* Ensure no pending spi operation in progress */
>> +    spi_nor_wait_till_ready(nor);
>> +
>>      spi_nor_restore(nor);
>>  }