linux-kernel - [PATCH] checkpatch: avoid warning about Possible repeated word: 'Google'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231013172739.1113964-1-kuba@kernel.org>
Date:   Fri, 13 Oct 2023 10:27:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     linux-kernel@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>, apw@...onical.com,
        joe@...ches.com, dwaipayanray1@...il.com, lukas.bulwahn@...il.com
Subject: [PATCH] checkpatch: avoid warning about Possible repeated word: 'Google'

syzbot stack traces often come with the following line:

 Hardware name: Google Google Compute Engine/Google Compute Engine...

This generates the repeated word warning from checkpatch.
It hit 49 times in the last 6 months in networking
(false-positive rate of 0.34%). Mute the warning for "Google",
there's no other word which comes close to being this clear
cut false-positive in our traffic.

Signed-off-by: Jakub Kicinski <kuba@...nel.org>
---
CC: apw@...onical.com
CC: joe@...ches.com
CC: dwaipayanray1@...il.com
CC: lukas.bulwahn@...il.com
---
 scripts/checkpatch.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7d16f863edf1..c99f8f93cb4c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3524,6 +3524,8 @@ sub process {
 
 				next if (lc($first) ne lc($second));
 				next if ($first eq 'long');
+				# syzbot reports contain "Hardware name: Google Google Compute Engine"
+				next if ($first eq 'Google');
 
 				# check for character before and after the word matches
 				my $start_char = '';
-- 
2.41.0